Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-15034 cherry-pick CLDR-17141 kbd: drop transform=no #3335

Merged
merged 2 commits into from
Oct 12, 2023
Merged

CLDR-15034 cherry-pick CLDR-17141 kbd: drop transform=no #3335

merged 2 commits into from
Oct 12, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 11, 2023 •
edited
Loading

  • expand documentation about use of markers to inhibit transforms

(cherry picked from commit 1a52361) #3330

CLDR-15034

  • This PR completes the ticket!!

ALLOW_MANY_COMMITS=true

@srl295 srl295 requested review from miloush and a team October 11, 2023 22:48
@srl295 srl295 self-assigned this Oct 11, 2023
@srl295 srl295 changed the title CLDR-15034: cherry-pick CLDR-17141 kbd: drop transform=no (#3330) CLDR-15034 cherry-pick CLDR-17141 kbd: drop transform=no (#3330) Oct 11, 2023
@srl295
CLDR-15034 cherry-pick CLDR-17141 kbd: drop transform=no (unicode-org…
9e7fa41 
…#3330)

- expand documentation about use of markers to inhibit transforms

(cherry picked from commit 1a52361)
@srl295 srl295 force-pushed the kbd/cldr-15034-cherrypick2 branch from 1ca85df to 9e7fa41 Compare October 11, 2023 22:49
@srl295 srl295 changed the title CLDR-15034 cherry-pick CLDR-17141 kbd: drop transform=no (#3330) CLDR-15034 cherry-pick CLDR-17141 kbd: drop transform=no Oct 11, 2023
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Oct 11, 2023 •
edited
Loading

this is the cherry pick though…  You're suppsoed to RSLGTM :]

@mcdurdin
Copy link
Contributor

RSLGTM

@srl295 srl295 requested a review from mcdurdin October 11, 2023 23:33
srl295 added a commit that referenced this pull request Oct 11, 2023
@srl295
CLDR-17141 kbd: Apply suggestions from code review
5ac7c53 
Co-authored-by: Marc Durdin <[email protected]>
(cherry picked from commit 85e182e in #3335)
@srl295 srl295 mentioned this pull request Oct 11, 2023
Merged
1 task
srl295 added a commit that referenced this pull request Oct 11, 2023
@srl295 @mcdurdin
CLDR-17141 kbd: Apply suggestions from code review
c9aab69 
(cherry picked from commit 85e182e in #3335)

Co-authored-by: Marc Durdin <[email protected]>
@srl295 srl295 merged commit fc7cf41 into unicode-org:maint/maint-44 Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@miloush miloush Awaiting requested review from miloush

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @mcdurdin