#87 constants.js added.

[VishalD51]

I have added constants.js and replace all hardcode value with constant defined.

---

Addresses: #87

Summary by CodeRabbit

• Refactor

  • Improved code readability and consistency in BreadcrumbNavigation and HierarchySwitcher components.
  • Enhanced error handling in breadcrumb navigation interactions.

• New Features

  • Integrated defaultRegion constant to standardize the initial state across navigation-related components.

• Style

  • Standardized code formatting and import statement styles in multiple components for better alignment with project code style guidelines.

• Documentation

  • No visible changes to end-user documentation.

[coderabbitai]

Walkthrough

The changes across various frontend components involve code reformatting for better readability, refactoring of functions for consistency, and the introduction of a new defaultRegion constant. This constant is imported and utilized in different components to standardize the default region setting. Error handling and message formatting have also been improved in some components.

Changes

File(s)	Change Summary
.../BreadcrumbNavigation.js	Code reformatted, fetchAndSetAncestors refactored, defaultRegion imported, and handleBreadcrumbClick function improved.
.../HierarchySwitcher.js, .../NavigationContext.js	Import statements reformatted, defaultRegion imported and used, error message format changed, and JSX structure improved.
.../constants.js	New defaultRegion constant introduced with specified properties.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment made by CodeRabbit.
• You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
• You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 359ffa4 and e9cb244.

Files selected for processing (4)

• frontend/src/components/BreadcrumbNavigation.js (1 hunks)
• frontend/src/components/HierarchySwitcher.js (3 hunks)
• frontend/src/components/NavigationContext.js (1 hunks)
• frontend/src/components/constants.js (1 hunks)

Additional comments: 12

frontend/src/components/BreadcrumbNavigation.js (4)

• 1-79: The refactoring of the BreadcrumbNavigation component, including the use of defaultRegion and the restructuring of functions for improved readability and error handling, aligns with best practices for maintainability and readability.

• 13-31: The useEffect hook's fetchAndSetAncestors function is well-structured and handles the case where selectedRegion.id is not null or 0. It also appropriately logs an error if the fetched ancestors are not an array.

• 33-59: The handleBreadcrumbClick function has been updated to improve readability and error handling. It now incorporates the defaultRegion constant and handles cases where regionId is null or 0, as well as errors during the fetching of a region.

• 13-31: The dependency array for the useEffect hook correctly includes selectedRegion and selectedHierarchy, ensuring that the effect runs when either of these values changes.

frontend/src/components/HierarchySwitcher.js (3)

• 1-5: The reformatting of import statements and the addition of defaultRegion import align with the project's move towards using constants for default values. This is a good practice for maintainability.

• 35-40: Using defaultRegion to reset the selected region when changing hierarchies is a good practice as it ensures consistency and reduces the risk of hard-coded values.

• 42-71: The JSX structure is well-formatted and readable, which aligns with best practices for React components.

frontend/src/components/NavigationContext.js (4)

• 3-3: The import of defaultRegion from './constants' is correctly implemented and used to initialize the selectedRegion state.

• 7-9: The indentation adjustment in the useNavigation function improves readability.

• 14-16: Verify if the hardcoded hierarchyId in the selectedHierarchy state should be replaced with a constant or dynamically set value.

• 18-30: The indentation and formatting within the NavigationProvider component are consistent and improve readability.

frontend/src/components/constants.js (1)

• 1-6: The defaultRegion constant is well-structured and follows best practices for defining constants in JavaScript. It will help in maintaining consistency across the application.

[OhmSpectator]

The changes related to the introduction of the defaultRegions constant look fine.

Nevertheless, avoid unnecessary code reformatting, please.

[VishalD51]

The changes related to the introduction of the defaultRegions constant look fine.

Nevertheless, avoid unnecessary code reformatting, please.

Thanks! @OhmSpectator , I will take care of it>

[VishalD51]

The changes related to the introduction of the defaultRegions constant look fine.
Nevertheless, avoid unnecessary code reformatting, please.

Thanks! @OhmSpectator , I will take care of it.

[OhmSpectator]

@VishalD51, I've updated the main branch to conform with Airbnb's Code Style. If you want to proceed with the PR, run npm run lint and npm run lint:fix to ensure adherence to the style guide.

[github-actions]

This PR has been inactive for a week. It will be closed in another week if there is no further activity.