-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Frontend, Refactor Hardcoded Values to Use Constants or Configuration #87
Labels
front
Issues related to Web UI
good first issue
Good for newcomers
refactoring
No new features, just refactoring
Comments
OhmSpectator
added
good first issue
Good for newcomers
front
Issues related to Web UI
refactoring
No new features, just refactoring
labels
Nov 26, 2023
@OhmSpectator I'm willing to work on this. Could you assign this issue to me, please? |
@VishalD51 ok! |
VishalD51
added a commit
to VishalD51/track-your-regions
that referenced
this issue
Nov 27, 2023
@OhmSpectator Can you please check this PR: #89 |
@VishalD51 thanks! I'll check the PR in the next few days. |
Closed
Closed
The default zoom level (9) from RegionMap should also be added to the constants. |
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
front
Issues related to Web UI
good first issue
Good for newcomers
refactoring
No new features, just refactoring
Description
Currently, several components set the selected region to a hardcoded value of 'World' or check against it. This approach can lead to potential issues with maintainability and flexibility as the application scales or undergoes changes.
Suggested Improvement
Refactor the code to replace hardcoded strings and values with constants or configuration objects. This will centralize the management of these values and make the codebase more maintainable.
Implementation Details
constants.js
file or a similar configuration file in thesrc
directory.HierarchySwitcher
component and any other components where hardcoded values are used.Benefits
Acceptance Criteria
The text was updated successfully, but these errors were encountered: