Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve #519 #611

Closed
wants to merge 1 commit into from
Closed

resolve #519 #611

wants to merge 1 commit into from

Conversation

kosarko
Copy link
Member

@kosarko kosarko commented Oct 7, 2016

Resolves #519 by introducing config variables (local.properties) that set paths to default.license and alternative.license
equivalent of the current setup is:

lr.default.license = ${dspace.dir}/config/default.license
lr.alternative.license = ${dspace.dir}/config/alternative.license

default.license has ${dspace.dir}/config/default.license as a default, but you at least have to introduce lr.default.license = (empty string) due to interpolation in lr.cfg

@amirkamran
Copy link

quoting from issue #519

If another centre needs to change default.license, they will have dirty tree.
If they want to localise it, dirty tree.

Suggestion:

use default.license.LOCALE
use filename to access default license in configuration
gitignore these files

I don't see the localization part in the commit.

@kosarko
Copy link
Member Author

kosarko commented Nov 21, 2016

quoting from issue #519

If another centre needs to change default.license, they will have dirty tree.
If they want to localise it, dirty tree.

Suggestion:

use default.license.LOCALE
use filename to access default license in configuration
gitignore these files
I don't see the localization part in the commit.

@vidiecan were you really after localized default licenses? At this point there are no localizations of those, with items we always store the default.license (the English one). The alternative CAN be displayed with non default_locale on /page/contract and in our case it IS a translation of the default one...but if we were to support third language it still would be the same "alternative one"...should this be changed?

with the changes above you can keep the tree without changes...you just configure paths in configs

@kosarko kosarko changed the base branch from lindat to clarin-dev November 22, 2016 10:02
@kosarko
Copy link
Member Author

kosarko commented Dec 5, 2016

closing...see the issue for details

@kosarko kosarko closed this Dec 5, 2016
@kosarko kosarko deleted the issue_#519 branch January 6, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants