Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify localising and changing licenses #519

Closed
vidiecan opened this issue Apr 13, 2016 · 4 comments
Closed

Simplify localising and changing licenses #519

vidiecan opened this issue Apr 13, 2016 · 4 comments

Comments

@vidiecan
Copy link

vidiecan commented Apr 13, 2016

If another centre needs to change default.license, they will have dirty tree.
If they want to localise it, dirty tree.

Suggestion:

  • use default.license.LOCALE
  • use filename to access default license in configuration
  • gitignore these files
@vidiecan vidiecan added this to the 2016 milestone Apr 18, 2016
@kosarko
Copy link
Member

kosarko commented Aug 29, 2016

related to #289/#491

@kosarko kosarko modified the milestones: 2016.09, 2016 Aug 29, 2016
@kosarko kosarko changed the title Simplify localising and changing licenses Simplify localising and changing licenses Aug 30, 2016
@kosarko kosarko self-assigned this Oct 6, 2016
@kosarko kosarko mentioned this issue Oct 7, 2016
@kosarko kosarko added Has PR and removed in progress labels Oct 7, 2016
@kosarko kosarko mentioned this issue Oct 7, 2016
@kosarko kosarko closed this as completed Dec 5, 2016
@kosarko kosarko removed the Has PR label Dec 5, 2016
@kosarko kosarko reopened this Dec 5, 2016
@kosarko
Copy link
Member

kosarko commented Dec 5, 2016

closed the #611 PR, after discussing with @vidiecan we should make the license part of messages...the localisation is then obvious

@vidiecan vidiecan modified the milestones: 2016.clarin.dspace, 2016.09 Dec 7, 2016
@vidiecan
Copy link
Author

vidiecan commented Dec 7, 2016

related to #622

@vidiecan
Copy link
Author

vidiecan commented Oct 9, 2017

moved to #662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants