Skip to content

Commit

Permalink
Fixes (#240)
Browse files Browse the repository at this point in the history
* fix ci

* fix analysis options

* update version n stuff

* update dependencies for example

* fix formatting command

* update goldens

* update goldens
  • Loading branch information
ueman authored Oct 3, 2023
1 parent eb0dc79 commit 24de10b
Show file tree
Hide file tree
Showing 11 changed files with 26 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/feedback.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
with:
channel: 'stable'
- run: flutter pub get
- run: flutter format -n --set-exit-if-changed .
- run: dart format --set-exit-if-changed .
- run: flutter analyze
- run: flutter test --coverage
- uses: codecov/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gitlab.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ jobs:
with:
channel: 'stable'
- run: flutter pub get
- run: flutter format -n --set-exit-if-changed .
- run: dart format --set-exit-if-changed .
- run: flutter analyze
- run: flutter test
2 changes: 1 addition & 1 deletion .github/workflows/sentry.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ jobs:
with:
channel: 'stable'
- run: flutter pub get
- run: flutter format -n --set-exit-if-changed .
- run: dart format --set-exit-if-changed .
- run: flutter analyze
- run: flutter test
5 changes: 5 additions & 0 deletions feedback/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## [3.0.0]

* Require Flutter 3.10.0
* Require Dart 3.0.0

## [2.6.0]

* Require Flutter 3.0.0
Expand Down
7 changes: 3 additions & 4 deletions feedback/example/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
include: package:flutter_lints/flutter.yaml

analyzer:
strong-mode:
implicit-casts: false
implicit-dynamic: false
language:
strict-raw-types: false
strict-raw-types: true
strict-inference: true
strict-casts: true
errors:
missing_required_param: error
missing_return: error
Expand Down
16 changes: 8 additions & 8 deletions feedback/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,23 @@ publish_to: none
version: 1.0.0+1

environment:
sdk: '>=2.12.0 <3.0.0'
flutter: '>=2.0.0'
sdk: '>=3.0.0 <4.0.0'
flutter: '>=3.10.0'

dependencies:
cupertino_icons: ^1.0.3
feedback:
path: ../../feedback
flutter:
sdk: flutter
flutter_email_sender: ^5.1.0
flutter_email_sender: ^6.0.2
flutter_localizations:
sdk: flutter
flutter_markdown: ^0.6.2
http: ^0.13.0
path_provider: ^2.0.10
share_plus: ^6.0.0
url_launcher: ^6.1.2
flutter_markdown: ^0.6.17
http: ^1.0.0
path_provider: ^2.1.1
share_plus: ^7.1.0
url_launcher: ^6.1.14

dev_dependencies:
flutter_lints: ^2.0.0
Expand Down
7 changes: 3 additions & 4 deletions feedback/lib/src/l18n/localization.dart
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,10 @@ class FeedbackLocalization extends StatelessWidget {

return Localizations(
delegates: mergedDelegates,
locale: localeOverride ?? _defaultLocale,
locale: localeOverride ??
View.maybeOf(context)?.platformDispatcher.locale ??
const Locale('en'),
child: child,
);
}
}

Locale get _defaultLocale =>
WidgetsFlutterBinding.ensureInitialized().window.locale;
2 changes: 1 addition & 1 deletion feedback/lib/src/utilities/media_query_from_window.dart
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class _MediaQueryFromWindowsState extends State<MediaQueryFromWindow>
@override
Widget build(BuildContext context) {
return MediaQuery(
data: MediaQueryData.fromWindow(_binding!.window),
data: MediaQueryData.fromView(View.of(context)),
child: widget.child,
);
}
Expand Down
6 changes: 3 additions & 3 deletions feedback/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
name: feedback
description: A Flutter package for getting better feedback. It allows the user to give interactive feedback directly in the app.
version: 2.6.0
version: 3.0.0
homepage: https://uekoetter.dev/
repository: https://github.com/ueman/feedback
issue_tracker: https://github.com/ueman/feedback/issues

environment:
sdk: '>=2.12.0 <3.0.0'
flutter: '>=3.0.0'
sdk: '>=3.0.0 <4.0.0'
flutter: '>=3.10.0'

dependencies:
flutter:
Expand Down
Binary file modified feedback/test/golden_images/closed_feedback.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified feedback/test/golden_images/open_feedback.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 24de10b

Please sign in to comment.