adds an exposed sheet contorller to the better feedback controller (#239

)
ueman · Sep 24, 2023 · eb0dc79 · eb0dc79
1 parent 80d5560
commit eb0dc79
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/feedback/example/android/build.gradle b/feedback/example/android/build.gradle
@@ -26,6 +26,6 @@ subprojects {
     project.evaluationDependsOn(':app')
 }
 
-task clean(type: Delete) {
+tasks.register("clean", Delete) {
     delete rootProject.buildDir
 }
diff --git a/feedback/lib/src/feedback_bottom_sheet.dart b/feedback/lib/src/feedback_bottom_sheet.dart
@@ -103,6 +103,7 @@ class _DraggableFeedbackSheetState extends State<_DraggableFeedbackSheet> {
         ),
         Expanded(
           child: DraggableScrollableSheet(
+            controller: BetterFeedback.of(context).sheetController,
             snap: true,
             minChildSize: collapsedHeight,
             initialChildSize: collapsedHeight,

diff --git a/feedback/lib/src/feedback_controller.dart b/feedback/lib/src/feedback_controller.dart
@@ -1,11 +1,11 @@
-import 'package:feedback/src/better_feedback.dart';
+import 'package:feedback/feedback.dart';
 import 'package:flutter/material.dart';
 
 /// Controls the state of the feeback ui.
 class FeedbackController extends ChangeNotifier {
   bool _isVisible = false;
 
-  /// Wether the feedback ui is currently visible.
+  /// Whether the feedback ui is currently visible.
   bool get isVisible => _isVisible;
 
   /// This function is called when the user submits his feedback.
@@ -27,4 +27,11 @@ class FeedbackController extends ChangeNotifier {
     _isVisible = false;
     notifyListeners();
   }
+
+  /// The draggable scrollable sheet controller used by better feedback.
+  ///
+  /// The controller is only attached if [FeedbackThemeData.sheetIsDraggable] is
+  /// true and feedback is currently displayed.
+  final DraggableScrollableController sheetController =
+      DraggableScrollableController();
 }
diff --git a/feedback/lib/src/feedback_widget.dart b/feedback/lib/src/feedback_widget.dart
@@ -57,7 +57,7 @@ class FeedbackWidgetState extends State<FeedbackWidget>
   // rebuilding the feedback sheet mid-drag cancels the drag.
   // TODO(caseycrogers): replace `sheetProgress` with a direct reference to
   //   `DraggableScrollableController` when the latter gets into production.
-  //   See: https://github.com/flutter/flutter/pull/92440.
+  //   See: https://github.com/flutter/flutter/pull/135366.
   ValueNotifier<double> sheetProgress = ValueNotifier(0);
 
   @visibleForTesting