-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(just): Add sourceable tooling for just and refine reorg #194
Conversation
3905adf
to
57d68b4
Compare
Reminder to myself: look into making a distrobox assemble function that is portable from myself on discord:
NOTE: this is just me brainstorming |
0956827
to
b56448f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wowsas... there's a lot here.
So, this PR seems to be at least PRs combined in one.
First, there's the stuff that directly applies to #186
Second, there's a bunch of stuff related to just file abstraction, theming, etc.
I'd really like to split this into distinct PRs because the first issue is a pre-existing issue which was created to solve a usability problem, and the second seems to be more of a developer refactor. May be valid, but it's better if we can grok them independently and give feedback to each respective goal.
Since it seems like you felt the refactor was helpful for the goal of cleaning up distrobox/toolbox usability... I'd suggest removing the distrobox/toolbox changes and focusing on the refactor first.
I will split them tomorrow after work then, it is late here |
Thanks for understanding and all the effort! No rush from me. |
i decided it isnt too much to get done before going to bed so splitting them now |
…d of hardcoded path
1cf4107
to
d3ae608
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve. 👍
The idea of this PR is to add a file that our just recipes can source which will import useful functionality like text formatting, colors and UI tools (instead of having to use the same ugum commands over and over)
NOTE: using the fallback bash version for demonstration purposes
Also please note that function names are not decided yet, these were chosen for demonstration purposes only.
This is very WIP and barebones, so i would like to gather any functionality, colors, formatting, etc. you would like added in here that would make sense.
if you are unsure about the bash color code for said color just give me the hex code for it and i will find the closest one available. 😄
Also where should we keep the source file?
/usr/libexec/ujust/
/usr/share/ublue-os/justlib/
other location that might make more sense?