Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(just): Add sourceable tooling for just and refine reorg #194

Merged
merged 49 commits into from
Jan 18, 2024

Conversation

HikariKnight
Copy link
Member

@HikariKnight HikariKnight commented Jan 13, 2024

The idea of this PR is to add a file that our just recipes can source which will import useful functionality like text formatting, colors and UI tools (instead of having to use the same ugum commands over and over)
image
image

image
NOTE: using the fallback bash version for demonstration purposes

Also please note that function names are not decided yet, these were chosen for demonstration purposes only.

This is very WIP and barebones, so i would like to gather any functionality, colors, formatting, etc. you would like added in here that would make sense.

if you are unsure about the bash color code for said color just give me the hex code for it and i will find the closest one available. 😄

Also where should we keep the source file?
/usr/libexec/ujust/
/usr/share/ublue-os/justlib/
other location that might make more sense?

@HikariKnight
Copy link
Member Author

Reminder to myself: look into making a distrobox assemble function that is portable

from myself on discord:

i think right now to avoid complexity, there will be 2 distrobox just recipes in config
distrobox-new image name [homedir] [extra_args]
alias distrobox=distrobox-new
distrobox-import [file] [extra_args]

import will list all distroboxes offered in the file and let the user select which one to assemble or they can just supply an arg to do all, etc
default file will be /etc/distrobox/distrobox.ini

NOTE: this is just me brainstorming

@HikariKnight HikariKnight force-pushed the hikariknight-just-tooling branch from 0956827 to b56448f Compare January 14, 2024 15:44
@HikariKnight HikariKnight changed the title feat(just): add sourceable bash script with ui tooling for just recipes feat(just): Add sourcable tooling for just and refine reorg Jan 15, 2024
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowsas... there's a lot here.

So, this PR seems to be at least PRs combined in one.

First, there's the stuff that directly applies to #186

Second, there's a bunch of stuff related to just file abstraction, theming, etc.

I'd really like to split this into distinct PRs because the first issue is a pre-existing issue which was created to solve a usability problem, and the second seems to be more of a developer refactor. May be valid, but it's better if we can grok them independently and give feedback to each respective goal.

Since it seems like you felt the refactor was helpful for the goal of cleaning up distrobox/toolbox usability... I'd suggest removing the distrobox/toolbox changes and focusing on the refactor first.

@HikariKnight
Copy link
Member Author

Wowsas... there's a lot here.

So, this PR seems to be at least PRs combined in one.

First, there's the stuff that directly applies to #186

Second, there's a bunch of stuff related to just file abstraction, theming, etc.

I'd really like to split this into distinct PRs because the first issue is a pre-existing issue which was created to solve a usability problem, and the second seems to be more of a developer refactor. May be valid, but it's better if we can grok them independently and give feedback to each respective goal.

Since it seems like you felt the refactor was helpful for the goal of cleaning up distrobox/toolbox usability... I'd suggest removing the distrobox/toolbox changes and focusing on the refactor first.

I will split them tomorrow after work then, it is late here

@bsherman
Copy link
Contributor

I will split them tomorrow after work then, it is late here

Thanks for understanding and all the effort! No rush from me.

@HikariKnight
Copy link
Member Author

I will split them tomorrow after work then, it is late here

Thanks for understanding and all the effort! No rush from me.

i decided it isnt too much to get done before going to bed so splitting them now

build/ublue-os-just/ublue-os-just.spec Outdated Show resolved Hide resolved
@HikariKnight HikariKnight force-pushed the hikariknight-just-tooling branch from 1cf4107 to d3ae608 Compare January 18, 2024 17:51
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. 👍

@castrojo castrojo enabled auto-merge January 18, 2024 18:15
@bsherman bsherman disabled auto-merge January 18, 2024 18:18
@bsherman bsherman enabled auto-merge January 18, 2024 18:18
@bsherman bsherman added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit a5eb2d4 Jan 18, 2024
2 checks passed
@bsherman bsherman deleted the hikariknight-just-tooling branch January 18, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants