Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(just): add distrobox tooling to just and cleanup distrobox just file #199

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

HikariKnight
Copy link
Member

split from #194

@KyleGospo
Copy link
Member

KyleGospo commented Jan 18, 2024

Bazzite will need changes based on this before it lands, a few of our just commands create a fedora distrobox and action upon it

Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :). DNM until Bazzite is up to speed

@HikariKnight
Copy link
Member Author

HikariKnight commented Jan 18, 2024

Bazzite will need changes based on this before it lands, a few of our just commands create a fedora distrobox and action upon it

Changes here should not affect bazzite as the container made for applications is the same one used in the old commands
but i will get a PR ready
edit: nvm i see where it is needed

@HikariKnight HikariKnight added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit ca1ca40 Jan 18, 2024
2 checks passed
@HikariKnight HikariKnight deleted the hikariknight-just-distrobox-refactor2 branch January 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants