Address audit report comments #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@202-reset-buffer-if-we-dont-return-the-hash
branch
5 times, most recently
from
6ac03c4
to
b3f6497
Compare
ajinkyaraj-23
changed the title
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@202-reset-buffer-if-we-dont-return-the-hash
branch
from
b3f6497
to
84a4c2a
Compare
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@202-reset-buffer-if-we-dont-return-the-hash
branch
9 times, most recently
from
f19880d
to
982a2fd
Compare
spalmer25
reviewed
Feb 13, 2024
| @@ -1,7 +1,5 @@ | |||
| /* Tezos Ledger application - Some common primitives and some command handlers | |||
|
|
|||
| TODO: split this file (apdu primitives and apdu handlers) | |||
There was a problem hiding this comment.
I'm not sure whether we have any trace of these TODOs.
Could you open an issue to make sure we don't forget them?
There was a problem hiding this comment.
What about this one in app/src/ui_stream_nbgl.c ?
// TODO: this is handled by change_screen_right except we disable it
// to use it here. We should make ui_stream fully compatible with
// exception.h
Is this TODO outdated ?
There was a problem hiding this comment.
Created #211 .
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@202-reset-buffer-if-we-dont-return-the-hash
branch
from
982a2fd
to
5b4e04c
Compare
|
Rebased on main. |
spalmer25
reviewed
Feb 14, 2024
There was a problem hiding this comment.
There is a forgotten FIXME in
ledger-app-tezos-wallet/app/src/ui_stream.h
Lines 154 to 155 in 5b4e04c
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@202-reset-buffer-if-we-dont-return-the-hash
branch
from
5b4e04c
to
a00fe3a
Compare
Fixed. The issue is same as #211 |
ajinkyaraj-23
force-pushed
the
ajinkyaraj-23@202-reset-buffer-if-we-dont-return-the-hash
branch
from
a00fe3a
to
4da7ac4
Compare
spalmer25
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #202