Fix unsigned int treated as int.

trilitech · Feb 14, 2024 · a00fe3a · a00fe3a
1 parent 44f62ff
commit a00fe3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/src/parser/operation_parser.c b/app/src/parser/operation_parser.c
@@ -419,7 +419,7 @@ tz_step_size(tz_parser_state *state)
     }
     op->frame->step_size.size = (op->frame->step_size.size << 8) | b;
     op->frame->step_size.size_len--;
-    if (op->frame->step_size.size_len <= 0) {
+    if (op->frame->step_size.size_len == 0) {
         op->frame[-1].stop = state->ofs + op->frame->step_size.size;
         tz_must(pop_frame(state));
     }
@@ -590,7 +590,7 @@ tz_step_read_int32(tz_parser_state *state)
     ASSERT_STEP(state, READ_INT32);
     tz_operation_state *op = &state->operation;
     uint8_t             b;
-    uint32_t           *value = &op->frame->step_read_int32.value;
+    int32_t            *value = &op->frame->step_read_int32.value;
     if (op->frame->step_read_int32.ofs < 4) {
         tz_must(tz_parser_read(state, &b));
         *value = (*value << 8) | b;

diff --git a/app/src/parser/operation_state.h b/app/src/parser/operation_state.h
@@ -147,8 +147,8 @@ typedef struct {
             uint8_t                 skip : 1, natural : 1;
         } step_read_num;
         struct {
-            uint32_t value;
-            uint8_t  skip : 1, ofs : 3;
+            int32_t value;
+            uint8_t skip : 1, ofs : 3;
         } step_read_int32;
         struct {
             uint16_t ofs;