Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Remove generation of packageEnables fragment file for Framework tests #13633

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Framework: Remove generation of packageEnables fragment file for Framework tests #13633

wants to merge 4 commits into from

Conversation

achauphan
Copy link
Contributor

@trilinos/framework

Motivation

Want to remove generation of packageEnables.cmake for PR builds that does not need to use the enabled packages from this generated packages.

The Framework PR build line has historically always generated a packageEnables.cmake similiar to other PR builds and ran tests that were unrelated to Framework's scripts. This uses unnecessary resources and has mislead users reading the Framework CDash build line.

Related Issues

Stakeholder Feedback

Testing

Since these are changes to the PR scripts themselves, the changes will test themselves in our CI, on both AutoTester1 and AutoTester2 systems.

The following behaviors should be observed before merging:

  • AutoTester1 and AutoTester2 Framework build line should ONLY run Framework tests
  • Configuration log should indicate that packageEnables.cmake generation was skipped

@achauphan
Add PR script argument to skip packageEnables.cmake creation
d3cb92d 
Add argument that can be passed downstream to skip the creation of the
packageEnables.cmake file to the main entry point of our PR script,
PullRequestLinuxDriverTest.py.

Signed-off-by: Anderson Chauphan <[email protected]>
@achauphan
Specify argument to skip packageEnables creation in AT1
0d8c4dc 
AutoTester1 begins its PR script from LaunchDriver.sh -> PullRequestLinuxDriver.sh
where arguments are propogated to the main PR script, PullRequestLinuxDriverTest.py.

Signed-off-by: Anderson Chauphan <[email protected]>
@achauphan
Add logic to skip create_package_enables_file
0ac49bf 
Added the logic that skips the creation of the packageEnables.cmake file
in Trilinos containing all the packages with changes that need to be enabled for
PR testing.

The implementation of current packageEnables generation writes to a hard-coded file
that does not take into consideration the existing `filename_packageenables` argument.
Further changes should be made such that the creation of the packageEnables file
depends on the value of the `filename_packageenables` instead of this
`skip-create-packageenables` flag, but here we are.

Signed-off-by: Anderson Chauphan <[email protected]>
@achauphan
Add --skip-create-packageenables arg to AT2 Framework tests
8999222 
Add argument to skip the creation of the packageEnables.cmake
fragment file for the Framework AT2 job. This job should not
run any other tests than Framework unittests, which was what it
was doing before due to the packageEnables.cmake file always being
generated along with the test being launched from the ctest-driver.

Signed-off-by: Anderson Chauphan <[email protected]>
@achauphan achauphan added PA: Framework Issues that fall under the Trilinos Framework Product Area AT2-SpecialApprove (Beta) Special approval label for AT2. labels Nov 26, 2024
@achauphan achauphan self-assigned this Nov 26, 2024
@achauphan achauphan requested a review from a team as a code owner November 26, 2024 01:51
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 837
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_gcc

  • Build Num: 887
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 888
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_clang

  • Build Num: 886
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4845
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_cuda

  • Build Num: 885
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_intel

  • Build Num: 806
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 885
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Using Repos:

Repo: TRILINOS (achauphan/Trilinos)
  • Branch: skip-package-enables
  • SHA: 8999222
  • Mode: TEST_REPO

Pull Request Author: achauphan

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED

Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run.

Pull Request Auto Testing has FAILED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 837
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_gcc

  • Build Num: 887
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 888
  • Status: FAILED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_clang

  • Build Num: 886
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4845
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_cuda

  • Build Num: 885
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_intel

  • Build Num: 806
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 885
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS PA: Framework;AT2-SpecialApprove
PULLREQUESTNUM 13633
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/achauphan/Trilinos
TRILINOS_SOURCE_SHA 8999222
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 6e2a9e8


CDash Test Results for PR# 13633.


Wiki: How to Reproduce PR Testing Builds and Errors.

sebrowne
sebrowne approved these changes Nov 26, 2024
View reviewed changes
packages/framework/pr_tools/PullRequestLinuxDriverTest.py
action="store_true",
help="Skip the creation of the packageEnables.cmake fragment file generated by " + \
"the TriBITS infrastructure indicating which packages are to be enabled based on file " + \
"changes between a source and target branch. Default=")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can lose the Default= if it doesn't have a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebrowne sebrowne sebrowne approved these changes

Assignees

@achauphan achauphan

Labels
AT2-SpecialApprove (Beta) Special approval label for AT2. PA: Framework Issues that fall under the Trilinos Framework Product Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achauphan @trilinos-autotester @sebrowne