Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Remove generation of packageEnables fragment file for Framework tests #13633

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Framework: Remove generation of packageEnables fragment file for Framework tests #13633

wants to merge 4 commits into from

Commits on Nov 26, 2024

  1. Add PR script argument to skip packageEnables.cmake creation 

    Add argument that can be passed downstream to skip the creation of the
packageEnables.cmake file to the main entry point of our PR script,
PullRequestLinuxDriverTest.py.

Signed-off-by: Anderson Chauphan <[email protected]>
    @achauphan
    achauphan committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    d3cb92d View commit details
    Browse the repository at this point in the history

  2. Specify argument to skip packageEnables creation in AT1 

    AutoTester1 begins its PR script from LaunchDriver.sh -> PullRequestLinuxDriver.sh
where arguments are propogated to the main PR script, PullRequestLinuxDriverTest.py.

Signed-off-by: Anderson Chauphan <[email protected]>
    @achauphan
    achauphan committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    0d8c4dc View commit details
    Browse the repository at this point in the history

  3. Add logic to skip create_package_enables_file 

    Added the logic that skips the creation of the packageEnables.cmake file
in Trilinos containing all the packages with changes that need to be enabled for
PR testing.

The implementation of current packageEnables generation writes to a hard-coded file
that does not take into consideration the existing `filename_packageenables` argument.
Further changes should be made such that the creation of the packageEnables file
depends on the value of the `filename_packageenables` instead of this
`skip-create-packageenables` flag, but here we are.

Signed-off-by: Anderson Chauphan <[email protected]>
    @achauphan
    achauphan committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    0ac49bf View commit details
    Browse the repository at this point in the history

  4. Add --skip-create-packageenables arg to AT2 Framework tests 

    Add argument to skip the creation of the packageEnables.cmake
fragment file for the Framework AT2 job. This job should not
run any other tests than Framework unittests, which was what it
was doing before due to the packageEnables.cmake file always being
generated along with the test being launched from the ctest-driver.

Signed-off-by: Anderson Chauphan <[email protected]>
    @achauphan
    achauphan committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8999222 View commit details
    Browse the repository at this point in the history