Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new shard for Rekor #250

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add new shard for Rekor #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions omniwitness/logs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ Logs:
PublicKey: rekor.sigstore.dev+c0d23d6a+AjBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABNhtmPtrWm3U1eQXBogSMdGvXwBcK5AW5i0hrZLOC96l+smGNM7nwZ4QvFK/4sueRoVj//QP22Ni4Qt9DPfkWLc=
Feeder: rekor
UseCompact: false
- Origin: rekor.sigstore.dev - 1193050959916656506
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able/would you consider shifting your origin string for new logs to the "schema-less URI" scheme described in the tlog-checkpoint spec?

e.g. rekor.sigstore.dev/1193050959916656506 might be one option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately didn't get a chance to do this yesterday before the sharding. We are tracking it in sigstore/rekor#2069. We will definitely do this with v2 tile-based Rekor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, wrong (but sort of related) issue, sigstore/rekor#1450 is it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, they can go in like this - nothing will break, and we can get them spec compliant on the next, hopefully Tessera-based, shard :)

URL: https://rekor.sigstore.dev?treeID=1193050959916656506
PublicKeyType: ecdsa
PublicKey: rekor.sigstore.dev+c0d23d6a+AjBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABNhtmPtrWm3U1eQXBogSMdGvXwBcK5AW5i0hrZLOC96l+smGNM7nwZ4QvFK/4sueRoVj//QP22Ni4Qt9DPfkWLc=
Feeder: rekor
UseCompact: false
- Origin: developers.google.com/android/binary_transparency/0
URL: https://developers.google.com/android/binary_transparency/
PublicKeyType: ecdsa
Expand Down
Loading