Add new shard for Rekor #250
Conversation
Tree ID is 1193050959916656506, key remains the same
| @@ -21,6 +21,12 @@ Logs: | |||
| PublicKey: rekor.sigstore.dev+c0d23d6a+AjBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABNhtmPtrWm3U1eQXBogSMdGvXwBcK5AW5i0hrZLOC96l+smGNM7nwZ4QvFK/4sueRoVj//QP22Ni4Qt9DPfkWLc= | |||
| Feeder: rekor | |||
| UseCompact: false | |||
| - Origin: rekor.sigstore.dev - 1193050959916656506 | |||
There was a problem hiding this comment.
Are you able/would you consider shifting your origin string for new logs to the "schema-less URI" scheme described in the tlog-checkpoint spec?
e.g. rekor.sigstore.dev/1193050959916656506 might be one option.
There was a problem hiding this comment.
Unfortunately didn't get a chance to do this yesterday before the sharding. We are tracking it in sigstore/rekor#2069. We will definitely do this with v2 tile-based Rekor.
There was a problem hiding this comment.
Sorry, wrong (but sort of related) issue, sigstore/rekor#1450 is it.
There was a problem hiding this comment.
No worries, they can go in like this - nothing will break, and we can get them spec compliant on the next, hopefully Tessera-based, shard :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
===========================================
- Coverage 51.05% 33.45% -17.60%
===========================================
Files 11 23 +12
Lines 903 1375 +472
===========================================
- Hits 461 460 -1
- Misses 374 820 +446
- Partials 68 95 +27 ☔ View full report in Codecov by Sentry. |
Tree ID is 1193050959916656506, key remains the same