Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generation iteration after writing checkpoint. #69

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Remove generation iteration after writing checkpoint. #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca9f84
Remove generation iteration after writing checkpoint.
jiggoha Jan 4, 2024
d6ef740
Merge branch 'main' into gen
jiggoha Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions experimental/gcp-log/internal/storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,12 @@ func (c *Client) SetNextSeq(num uint64) {
}

// WriteCheckpoint stores a raw log checkpoint on GCS if it matches the
// generation that the client thinks the checkpoint is.
// generation that the client thinks the checkpoint is. The client updates the
// generation number of the checkpoint whenever ReadCheckpoint is called.
//
// This method will fail to write if 1) the checkpoint exists and the client
// has never read it or 2) the checkpoint has been updated since the client
// called ReadCheckpoint.
func (c *Client) WriteCheckpoint(ctx context.Context, newCPRaw []byte) error {
bkt := c.gcsClient.Bucket(c.bucket)
obj := bkt.Object(layout.CheckpointPath)
Expand All @@ -160,7 +165,6 @@ func (c *Client) WriteCheckpoint(ctx context.Context, newCPRaw []byte) error {
if _, err := w.Write(newCPRaw); err != nil {
return err
}
c.checkpointGen++
return w.Close()
}

Expand Down
Loading