Remove generation iteration after writing checkpoint. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 55.99% 55.99%
=======================================
Files 8 8
Lines 759 759
=======================================
Hits 425 425
Misses 265 265
Partials 69 69 ☔ View full report in Codecov by Sentry. |
AlCutter
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generation numbers are only monotonically increasing and not necessarily
[0, 1, 2, ...](FYI: metageneration numbers are): example here.Remove code assuming the generation number of the new version after writing a checkpoint. Practically speaking, if there is no race condition, a client's knowledge about the checkpoint generation will match the truth in GCS, since the client always calls ReadCheckpoint before WriteCheckpoint. If there is a race condition, then a client's knowledge about the checkpoint generation will be out of date, and the write will fail because the precondition of the generation number will not match.