Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextage_ik_plugin] In harmonize function: Limit angles to [-2*PI; 2*PI] #342

Open
wants to merge 1 commit into
base: indigo-devel
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jun 27, 2017

Hi,
I am reporting a minor bug about the harmonize function inside the two next files (line 482, indigo-devel branch):
rtmros_nextage/nextage_ik_plugin/src/nextage_left_arm_ikfast_moveit_plugin.cpp
rtmros_nextage/nextage_ik_plugin/src/nextage_right_arm_ikfast_moveit_plugin.cpp

A minus sign was missing in order to properly limit the angles in [-2PI; 2PI]
It is fixed with this pull request. It was tested with the simulator.

Regards,
Yoann.

@ghost ghost mentioned this pull request Jun 27, 2017
@130s 130s requested a review from k-okada June 27, 2017 18:37
@k-okada
Copy link
Member

k-okada commented Jun 27, 2017

  1. please provide a example/test code to reproduce the problem
  2. if your investigation is correct, that's because of https://github.com/ros-planning/moveit/blob/c9228603c58c260437a56c94233210b6dbab3def/moveit_kinematics/ikfast_kinematics_plugin/templates/ikfast61_moveit_plugin_template.cpp#L564-L585, you'd better to send pull request to https://github.com/ros-planning/moveit and assign @130s ;-)

@130s
Copy link
Contributor

130s commented Jun 28, 2017

I'm not keen on ikfast so no need to point to me. Plenty others are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants