Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKFast plugin: Minor fix to apply #341

Closed
ghost opened this issue Jun 27, 2017 · 3 comments
Closed

IKFast plugin: Minor fix to apply #341

ghost opened this issue Jun 27, 2017 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jun 27, 2017

Hi all,

I am reporting a minor bug about the harmonize function inside the two next files (line 482, indigo-devel branch):

  • rtmros_nextage/nextage_ik_plugin/src/nextage_left_arm_ikfast_moveit_plugin.cpp
  • rtmros_nextage/nextage_ik_plugin/src/nextage_right_arm_ikfast_moveit_plugin.cpp

A minus sign is missing in order to properly bound the angles in [-2PI; 2PI]
line 482: while(solution[i] < -2*M_PI) { ...

Regards,
Yoann.

@130s
Copy link
Contributor

130s commented Jun 27, 2017

Thanks for the headsup. A few questions:

  • Have you confirmed the suggested change works? On simulator or on the real robot?
  • Do you think you can open a pull request?

Either way I'd like to ask @k-okada for taking care of this.

@ghost
Copy link
Author

ghost commented Jun 27, 2017

Hi 130s,

It was tested with the simulator and it works.
I have created the pull request: #342

Regards,
Yoann.

@130s
Copy link
Contributor

130s commented Jun 27, 2017

Thanks!
Continued in #342

@130s 130s closed this as completed Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants