Add debugpy support & implement bundle property to raw-image yaml & schema fixes & vs code pylint support #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microhobby
force-pushed
the
castello/series1
branch
from
3eede06 to
793f923
Compare
jsrc27
reviewed
Oct 17, 2024
|
Seems like pylint is complaining. Could you fix what it's complaining about or disable the check for the section pylint is complaining about if needed. |
Yeah, I will handle this. |
microhobby
force-pushed
the
castello/series1
branch
7 times, most recently
from
5f3c468 to
a94a37c
Compare
microhobby
changed the title
microhobby
force-pushed
the
castello/series1
branch
4 times, most recently
from
ff9c4c8 to
900e0f0
Compare
Checks if the TCB_DEBUGPY environment variable is set, if so, it means that a developer is trying to debug the code from outside, so, we wait for a debugger to attach to the process. Also add the .vscode/launch.json configuration to attach to the running process. Signed-off-by: Matheus Castello <[email protected]>
This patch adds support for the bundle property into the raw-image, this way users can define a docker-compose file to be bundled and deployed into the new output raw image. Signed-off-by: Matheus Castello <[email protected]>
This meta is deprecated, was used only on IDE v1, is better to use the already implemented file with extensions yml and yaml. Signed-off-by: Matheus Castello <[email protected]>
The tdxMeta should not be used here, this was a mistake that causes the IDE v2 to try to validate the filesystem as string instead of a list of strings. Signed-off-by: Matheus Castello <[email protected]>
Signed-off-by: Matheus Castello <[email protected]>
microhobby
force-pushed
the
castello/series1
branch
from
900e0f0 to
1d1a81e
Compare
|
Gave the latest revision another look over. Looks a lot better now that the raw image flow is more in-line with the tezi image flow. |
jsrc27
reviewed
Oct 21, 2024
|
As internally discussed with @microhobby , I'll take care of the PR from now on. I plan to keep the current commits and just add the necessary fixes/suggestions. |
lucas-akira
reviewed
Oct 23, 2024
|
Edit: Just got direct access to the forked repo and I can push to it now. |
jsrc27
approved these changes
Oct 30, 2024
|
@rborn-tx Did you want to take a look at this as well? |
@jsrc27 Yes! I hope to be able to do it today. |
rborn-tx
reviewed
Oct 30, 2024
rborn-tx
reviewed
Oct 30, 2024
The bundle command will now automatically compress the docker bundle tarfile (docker-storage.tar) if 'output_filename' from download_containers_by_compose_file() ends with certain extensions like .gz, .xz, etc. Otherwise, no compression will be done to the tarfile. This was done because compression isn't necessary when bundling container images on raw images with the build command, as the docker bundle tarfile will be immediately unpacked on the rootfs of the output OS image. A compressed tarfile takes longer to unpack compared to an uncompressed one, adding unnecessary processing time that could be avoided. Signed-off-by: Lucas Akira Morishita <[email protected]>
When the handle_bundle_common() function was introduced, the build command unintentionally started deleting bundle directories after combining container images, regardless if the directory was a temporary one or not. This commit restores the original intended behavior of only removing bundle directories created when a docker compose yaml file is passed to the 'bundle' section instead of a complete directory. Signed-off-by: Lucas Akira Morishita <[email protected]>
Signed-off-by: Lucas Akira Morishita <[email protected]>
Include bundle options to raw images, as they're now supported. Signed-off-by: Lucas Akira Morishita <[email protected]>
In update_dt_git_repo(), the code was incorrectly passing a GitPython Head object as the refspec argument in the Remote.fetch() method, which should be a string or list of strings. Newer versions of GitPython added a check that verifies if refspec is of the expected type, throwing an error if that isn't the case. Because of this the 'dt checkout --update' command fails if TCB was built with recent versions of the GitPython library. This commit removes the unnecessary refspec argument. Signed-off-by: Lucas Akira Morishita <[email protected]>
lucas-akira
force-pushed
the
castello/series1
branch
from
eeed8ca to
66bf325
Compare
Right, I'll add the tests then. |
Signed-off-by: Lucas Akira Morishita <[email protected]>
Signed-off-by: Lucas Akira Morishita <[email protected]>
rborn-tx
approved these changes
Nov 4, 2024
lucas-akira
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series:
Open to suggestions from maintainers.