Skip to content

Commit

Permalink
common.py: Change 'device-tree' repo update process used for TC5 images
Browse files Browse the repository at this point in the history
In update_dt_git_repo(), the code was incorrectly passing a GitPython
Head object as the refspec argument in the Remote.fetch() method, which
should be a string or list of strings.

Newer versions of GitPython added a check that verifies if refspec is of
the expected type, throwing an error if that isn't the case. Because of
this the 'dt checkout --update' command fails if TCB was built with recent
versions of the GitPython library.

This commit removes the unnecessary refspec argument.

Signed-off-by: Lucas Akira Morishita <[email protected]>
  • Loading branch information
lucas-akira committed Oct 29, 2024
1 parent bd6bd6a commit eeed8ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tcbuilder/backend/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ def update_dt_git_repo():
try:
repo_obj = git.Repo(os.path.abspath("device-trees"))
sha = repo_obj.head.object.hexsha
repo_obj.remotes["origin"].fetch(repo_obj.active_branch)
repo_obj.remotes["origin"].fetch()
repo_obj.remotes["origin"].pull()
set_output_ownership("device-trees")
log.info("'device-trees' is already up to date"
Expand Down

0 comments on commit eeed8ca

Please sign in to comment.