Simplify the way yarn-install action ensures yarn.lock stays unchanged after yarn install

[ascrazy]

Background

I have faced a problem integrating yarn-install action into tracker-front where we have yarn.lock that gets all packages through registry.yarnpkg.com, so not a single mention of registry.npmjs.com is there, and this leads to Change registry in yarn.lock file to npm Artifact Registry step failing with an error (e.g. https://github.com/toptal/tracker-front/actions/runs/12527127099/job/34940394300?pr=3264)

Initially tried to hunt down and fix this specific problem, but debugging this quite complex bash script came to conclusion it's kind of overengineered and we can achieve the same behavior with much more simple and even more performant implementation. Thus this is my suggestion

Description

The idea if existing implementation is that after running yarn install we process entire yarn.lock and undo any registry overrides that we've done previously so we can compare yarn.lock after yarn install to one in git index.

The idea of updated implementation is that we capture checksum of the yarn.lock right before running yarn install (with overridden URLs) and compare it to checksum after yarn install

How to test

• Check yarn-install works as expected on different toptal repos
• • success path - yarn-install passes when yarn.lock is up to date with package.json
• • failure path - yarn-install fails when yarn.lock is to up to date with package.json
• toptal/staff-portal
• • success path - https://github.com/toptal/staff-portal/actions/runs/12668795818/job/35304940896?pr=14098#step:7:592
• • failure path - https://github.com/toptal/staff-portal/actions/runs/12668795818/job/35304940896?pr=14098#step:7:592
• toptal/hire-global
• • success path - https://github.com/toptal/hire-global/actions/runs/12640219148/job/35220183956?pr=520#step:7:556
• • failure path - https://github.com/toptal/hire-global/actions/runs/12640053550/job/35219662580?pr=520#step:7:583

Development checks

• Add changeset according to guidelines (if needed)

PR commands

List of available commands:

• @toptal-anvil ping reviewers - Ping teams for review

[changeset-bot]

🦋 Changeset detected

Latest commit: e11f730

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
davinci-github-actions	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ascrazy]

Hi @sashuk,

I've noticed you were involved into testing of #295 when many of those bash scripts I'm modifying here were introduced, so could you please have a look at this PR and share what do you think of my suggestion? Maybe you know any pitfalls I might be missing?

[sashuk]

Thank you for testing it in two apps, looks good!

[ascrazy]

I have addressed the concerns raised by @sashuk and @pudek357 and re-rested on toptal/staff-portal and on toptal/platform https://github.com/toptal/platform/actions/runs/12673183166/job/35318966291#step:11:624

[pudek357]

Great job!