-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TAPS-425] Improve yarn-install action #370
Conversation
|
5be804c
to
2374e16
Compare
Hi @pudek357, I ran into the same problem ~2 weeks ago and looking for a resolution came up with idea that we can significantly simplify yarn-install action. Please have a look at this PR #369. Would be cool if you could test it on your use case. Upd: I have tested #369 on toptal/hire-global and toptal/staff-portal and it works as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested, by the idea is clear and code looks valid 👍
|
TAPS-425
Description
This PR aims to improve
yarn-install
action for scenario when there is no occurrence ofregistry.npmjs.org
insideyarn.lock
. We have this case in screening-wizard-frontend.How to test
yarn-install
into platform to test changes: https://github.com/toptal/platform/pull/80504/files)Development checks
PR commands
List of available commands:
@toptal-anvil ping reviewers
- Ping teams for review