Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAPS-425] Improve yarn-install action #370

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

pudek357
Copy link
Contributor

@pudek357 pudek357 commented Jan 6, 2025

TAPS-425

Description

This PR aims to improve yarn-install action for scenario when there is no occurrence of registry.npmjs.org inside yarn.lock. We have this case in screening-wizard-frontend.

How to test

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping teams for review

@pudek357 pudek357 self-assigned this Jan 6, 2025
@pudek357 pudek357 requested a review from a team as a code owner January 6, 2025 13:38
Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: 5be804c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pudek357 pudek357 force-pushed the TAPS-425-improve-yarn-install-action branch from 5be804c to 2374e16 Compare January 6, 2025 13:43
@ascrazy
Copy link
Contributor

ascrazy commented Jan 6, 2025

Hi @pudek357,

I ran into the same problem ~2 weeks ago and looking for a resolution came up with idea that we can significantly simplify yarn-install action. Please have a look at this PR #369. Would be cool if you could test it on your use case.

Upd: I have tested #369 on toptal/hire-global and toptal/staff-portal and it works as expected

yarn-install/action.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@denieler denieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, by the idea is clear and code looks valid 👍

@pudek357 pudek357 merged commit ea00828 into master Jan 7, 2025
4 of 5 checks passed
@pudek357 pudek357 deleted the TAPS-425-improve-yarn-install-action branch January 7, 2025 01:51
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
@pudek357
Copy link
Contributor Author

pudek357 commented Jan 7, 2025

Hi @pudek357,

I ran into the same problem ~2 weeks ago and looking for a resolution came up with idea that we can significantly simplify yarn-install action. Please have a look at this PR #369. Would be cool if you could test it on your use case.

Upd: I have tested #369 on toptal/hire-global and toptal/staff-portal and it works as expected

@ascrazy I will answer in #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants