Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default value of docker-file parameter #215

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

sashuk
Copy link
Collaborator

@sashuk sashuk commented Oct 12, 2023

FX-4401

Description

As a follow-up of https://github.com/toptal/davinci/pull/2166, davinci-github-actions/build-push-image action now has docker-file parameter changed (the old Dockerfile is deleted from davinci-ci)

How to test

  • Configuration update, all checks should pass

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping FX team for review

@sashuk sashuk self-assigned this Oct 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: c701481

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
davinci-github-actions Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk changed the title fix: make docker-file mandatory feat: change default value of docker-file parameter Oct 12, 2023
@sashuk sashuk marked this pull request as ready for review October 12, 2023 12:07
@sashuk sashuk requested a review from a team October 12, 2023 12:07
@sashuk
Copy link
Collaborator Author

sashuk commented Oct 13, 2023

@toptal-anvil ping reviewers

@sashuk sashuk merged commit c9298a9 into master Oct 21, 2023
7 of 8 checks passed
@sashuk sashuk deleted the FX-NULL-make-docker-file-mandatory branch October 21, 2023 18:43
@github-actions github-actions bot mentioned this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants