feat: change default value of docker-file parameter (#215)

toptal · Oct 21, 2023 · c9298a9 · c9298a9
1 parent 84bae07
commit c9298a9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/.changeset/spicy-ears-share.md b/.changeset/spicy-ears-share.md
@@ -0,0 +1,5 @@
+---
+'davinci-github-actions': major
+---
+
+- change default value of `docker-file` parameter in `davinci-github-actions/build-push-image` action
diff --git a/build-push-image/README.md b/build-push-image/README.md
@@ -12,14 +12,14 @@ This GH Action builds a Docker image and pushes to google cloud.
 
 The list of arguments, that are used in GH Action:
 
-| name             | type                                                        | required | default                                             | description                                                                                |
-| ---------------- | ----------------------------------------------------------- | -------- | --------------------------------------------------- | ------------------------------------------------------------------------------------------ |
-| `sha`            | string                                                      | ✅        |                                                     | Commit hash that will be used as a tag for the Docker image                                |
-| `image-name`     | string                                                      | ✅        |                                                     | Name of the Docker image. Might be used in the next steps (for ex.: deploy a Docker image) |
-| `environment`    | enum<<br/>`temploy`,<br/>`staging`,<br/>`production`,<br/>> |          | staging                                             | Determines additional procedures while creating a Docker image.                            |
-| `build-args`     | string                                                      | ✅        |                                                     | Multiline string to describe build arguments that will be used during dockerization        |
-| `docker-file`    | string                                                      |          | ./davinci/packages/ci/src/configs/docker/Dockerfile | pathname to Docker file                                                                    |
-| `davinci-branch` | string                                                      |          | master                                              | Custom davinci branch                                                                      |
+| name             | type                                                        | required | default                                                        | description                                                                                |
+| ---------------- | ----------------------------------------------------------- | -------- | -------------------------------------------------------------- | ------------------------------------------------------------------------------------------ |
+| `sha`            | string                                                      | ✅        |                                                                | Commit hash that will be used as a tag for the Docker image                                |
+| `image-name`     | string                                                      | ✅        |                                                                | Name of the Docker image. Might be used in the next steps (for ex.: deploy a Docker image) |
+| `environment`    | enum<<br/>`temploy`,<br/>`staging`,<br/>`production`,<br/>> |          | staging                                                        | Determines additional procedures while creating a Docker image.                            |
+| `build-args`     | string                                                      | ✅        |                                                                | Multiline string to describe build arguments that will be used during dockerization        |
+| `docker-file`    | string                                                      |          | ./davinci/packages/ci/src/configs/docker/Dockerfile.gha-deploy | pathname to Docker file                                                                    |
+| `davinci-branch` | string                                                      |          | master                                                         | Custom davinci branch                                                                      |
 
 ### Outputs
 

diff --git a/build-push-image/action.yml b/build-push-image/action.yml
@@ -23,7 +23,7 @@ inputs:
   docker-file:
     description: 'pathname to Docker file'
     required: false
-    default: ./davinci/packages/ci/src/configs/docker/Dockerfile
+    default: ./davinci/packages/ci/src/configs/docker/Dockerfile.gha-deploy
   davinci-branch:
     description: 'Custom davinci branch'
     required: false