Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clean up Descriptors section #68

Merged
merged 6 commits into from
Dec 23, 2024
Merged

doc: clean up Descriptors section #68

merged 6 commits into from
Dec 23, 2024

Conversation

tomlogic
Copy link
Owner

@tomlogic tomlogic commented Dec 13, 2024

Addresses #58 and #59.

Need to do a few more things:

@tomlogic
Copy link
Owner Author

@francisdb, this is ready for review.

I've updated my Python implementation to support the new _nibble setting, and updated some of the files to use it instead of having a nibble property on every entry.

I think it might be possible to update normalize-map.py to identify maps that have an identical nibble setting on all entries, add a _nibble to the file, and then remove the nibble settings. I just manually edited the three map files of this PR.

We won't use it on robo_a34 since most of the entries use full bytes.
@francisdb
Copy link
Contributor

Looks good :shipit:

@tomlogic tomlogic merged commit cba574e into master Dec 23, 2024
1 check passed
@tomlogic tomlogic deleted the feature/doc_update branch December 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants