Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stagex refactor #433

Merged
merged 57 commits into from
Jun 7, 2024
Merged

stagex refactor #433

merged 57 commits into from
Jun 7, 2024

Conversation

lrvick
Copy link
Contributor

@lrvick lrvick commented Feb 13, 2024

Highlights

  • git lfs artifacts removed
  • toolchain removed
  • make flow dramatically simplified. Single file.
  • all actual build steps now handled in overhauled containerfiles in src/images
  • make: deterministically build all the things with stagex build container
  • make test: run all tests in build container
  • make lint: run automated linting from build container
    • disabled as current code does not pass linting
  • make format: run rustfmt from build container
  • make docs: run rustdocs from build container
  • make gen: run "make -C proto" under stagex with stagex-provided tools
  • CI refactored to use all of the above exactly as you would locally

@lrvick lrvick force-pushed the lance/stagex-refactor branch from 9e2978d to 139ea33 Compare February 17, 2024 04:35
@lrvick lrvick force-pushed the lance/stagex-refactor branch from 725ae22 to 25a8193 Compare February 28, 2024 20:03
Makefile Outdated
Comment on lines 88 to 89
cd out/build-base; \
tar -cf - . | docker load
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this change the directory for the following touch command as well?

Suggested change
cd out/build-base; \
tar -cf - . | docker load
(cd out/build-base; tar -cf - . | docker load)

or can you use the the -C argument to tar?

-C, --directory=DIR
              Change to DIR before performing any operations.  This option is order-sensitive, i.e. it affects all options that follow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macs dont have -C sadly. that is why I remove -C

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know mac env doesn't have -C but I thought their tar would.

emostov
emostov previously approved these changes Mar 15, 2024
emostov
emostov previously approved these changes Mar 19, 2024
@r-n-o r-n-o merged commit 0e5aed2 into main Jun 7, 2024
4 checks passed
@r-n-o r-n-o deleted the lance/stagex-refactor branch June 7, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants