Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Containers: save space by deleting apt lists #436

Closed
wants to merge 1 commit into from
Closed

Containers: save space by deleting apt lists #436

wants to merge 1 commit into from

Conversation

cr-tk
Copy link
Collaborator

@cr-tk cr-tk commented Feb 23, 2024

Summary & Motivation (Problem vs. Solution)

Save ~18 MB per container by not storing unnecessary apt lists.

How I Tested These Changes

Building the Dockerfile.

Pre merge check list

No functional changes, no changelog entry required.

@cr-tk cr-tk added the enhancement New feature or request label Feb 23, 2024
@cr-tk cr-tk requested review from lrvick and emostov February 23, 2024 14:23
@cr-tk
Copy link
Collaborator Author

cr-tk commented Apr 23, 2024

@emostov @lrvick this is a fairly straightforward PR, any chance you can take a review look soon?

From what I can tell, the failing tests are flaky.

emostov
emostov approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but since we are switching to stagex imminently with #433 it will be irrelevant soon

@cr-tk
Copy link
Collaborator Author

cr-tk commented Apr 25, 2024

@emostov that's a good point. Do you think the extra effort caused by bringing it to main at this point makes it worth not merging?

@cr-tk
Copy link
Collaborator Author

cr-tk commented Jun 17, 2024

This PR is now obsolete since #433 removed the Dockerfile files in question.

@cr-tk cr-tk closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emostov emostov emostov approved these changes

@lrvick lrvick Awaiting requested review from lrvick

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cr-tk @emostov