Add functionality for users to retrieve template by Name as well as UUID #541
Conversation
Signed-off-by: William Belcher <[email protected]>
Signed-off-by: William Belcher <[email protected]>
Signed-off-by: William Belcher <[email protected]>
|
@tstromberg I have once again accidentally closed my last PR... Doh!! Here is a new one with the minor tweaks you requested. Let me know if there's anything else you'd like touched up! |
|
Hey @Belchy06, thanks for submitting this! Looks like it just needs some checks to be looked at. |
jacobweinstock
added
kind/feature
Signed-off-by: William Belcher <[email protected]>
|
Hey @Belchy06, looks like a couple of checks and a merge conflict need attention. Anything I can do to help with this? |
|
@jacobweinstock Sorry Jacob. I'm just in the middle of my university studies and have a few weeks of the semester left before I can commit some time to working on this again. I'm more than happy to put some time into it, just a matter of getting through the semester first. |
Lots of fixes to stuff that is dynamically generated along with a few extra bits here and there in related code to make things better. - [x] Fixes the `go generate` calls - [x] Changes protobuf/grpc stuff to use buf for both dependency management and building/calling protoc - [x] Changes from goimports to gofumpt as we want this anyway - [x] Build the tools in tools.go via the Makefile - [x] Dropped protoc-gen-doc support as that seemed unused. (easy to bring back when we have a use for it) - [x] Add a make target to check that the generated files are up to date - [x] Prettier-ify the GHA yaml files too (not just *.yml files) - [x] Update README/docs - [x] Setup CI to ensure files are up to date <!--- Please describe what this PR is going to change --> Mostly fixes for dynamically generated files. <!--- Link to issue you have raised --> I noticed that #541 had some protobuf format commits which I was not expecting being done separately. I went looking into it and noticed the mess we're in. ## How Has This Been Tested? CI ## How are existing users impacted? What migration steps/scripts do we need? Will have better automation for messing with generated files. ## Checklist: I have: - [x] updated the documentation and/or roadmap (if required) - [x] added unit or e2e tests - [ ] provided instructions on how to upgrade
|
Hey @Belchy06 can you rebase on top of latest main, I've done a bunch of work fixing the generators so the edit you made to template.pb.go should be unnecessary. |
|
@Belchy06 I've rebased on top of main and tweaked your PR a little further. Can you verify that "Allow edits from maintainers" is checked? I'd like to update with my changes in pull-541-tweaks. I still get confused whether or not that will actually work with organization type repos. If not I'll just open up a separate PR (4th time's the charm!) |
@Belchy06 is this something you're still working on? |
|
I'd say lets close this and I'll PR my branch that is based on this one. |
|
I've opened up a draft PR (#553) that should replace this one. It's still a draft because I have not tested it myself. |
Signed-off-by: William Belcher [email protected]
Description
This PR adds the ability for Tink to retrieve workflows by either UUID or by Name. If the value after
tink template getis not a valid UUID, Tink will default to searching for the value in the Name field of the templates.This PR also adds a TemplateClient to the Tink client, allowing other services such as Boots to retrieve templates.
Why is this needed
This feature is required for the project I am working on but I am sure there are many other use cases I'm unaware of. Also, tinkerbell/smee#178
How Has This Been Tested?
This has been tested in the VM's based on the Local Setup with Vagrant tutorial, as well as in our personal deployment
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: