Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for users to retrieve template by Name as well as UUID #516

Closed
wants to merge 1 commit into from

Conversation

Belchy06
Copy link
Contributor

Description

This PR adds the ability for Tink to retrieve workflows by either UUID or by Name. If the value after tink template get is not a valid UUID, Tink will default to searching for the value in the Name field of the templates.

This PR also adds a TemplateClient to the TInk client, allowing other services such as Boots to retrieve templates.

Why is this needed

This feature is required for the project I am working on but I am sure there are many other use cases I'm unaware of. Also, tinkerbell/smee#178

How Has This Been Tested?

This has been tested in the VM's based on the Local Setup with Vagrant tutorial.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@tstromberg
Copy link
Contributor

tstromberg commented Aug 24, 2021

Looks good to me. Can you fix the DCO sign-off so that we could merge this?

git commit --amend --no-edit --signoff
git push --force-with-lease origin master

Signed-off-by: William Belcher <[email protected]>
@rgl
Copy link
Contributor

rgl commented Oct 6, 2021

@Belchy06, was there a reason for closing this PR? Was it superseded by another one?

@mmlb
Copy link
Contributor

mmlb commented Oct 19, 2021

Looks like it was mistakenly closed and then opened as a new PR in #523, which was also mistakenly close and opened as a new PR in #541.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants