Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABI issue when upgrading PG from 15.3 to 15.4+ #7589

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix ABI issue when upgrading PG from 15.3 to 15.4+ #7589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions tsl/src/compression/api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,15 +786,30 @@ set_access_method(Oid relid, const char *amname)
AlterTableInternal(relid, list_make1(&cmd), false);

#if (PG_VERSION_NUM < 150004)
/* Fix for PostgreSQL bug where pg_depend was not updated to reflect the
* new dependency between AM and relation. See related PG fix here:
* https://github.com/postgres/postgres/commit/97d89101045fac8cb36f4ef6c08526ea0841a596 */
if (changeDependencyFor(RelationRelationId, relid, AccessMethodRelationId, amoid, new_amoid) !=
1)
elog(ERROR,
"could not change access method dependency for relation \"%s.%s\"",
get_namespace_name(get_rel_namespace(relid)),
get_rel_name(relid));

/*
* Also do a runtime check in order to be ABI compatible with PG server
* upgrades, e.g., upgrading from 15.3 to 15.4 without updating the
* extension.
*/
const char *version_num_str = GetConfigOption("server_version_num", false, false);
int server_version_num;

if (parse_int(version_num_str, &server_version_num, 0, NULL) && server_version_num < 150004)
{
/* Fix for PostgreSQL bug where pg_depend was not updated to reflect the
* new dependency between AM and relation. See related PG fix here:
* https://github.com/postgres/postgres/commit/97d89101045fac8cb36f4ef6c08526ea0841a596 */
if (changeDependencyFor(RelationRelationId,
relid,
AccessMethodRelationId,
amoid,
new_amoid) != 1)
elog(ERROR,
"could not change access method dependency for relation \"%s.%s\"",
get_namespace_name(get_rel_namespace(relid)),
get_rel_name(relid));
}
#endif
hypercore_alter_access_method_finish(relid, !to_hypercore);

Expand Down
Loading