Fix ABI issue when upgrading PG from 15.3 to 15.4+ #7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7589 +/- ##
==========================================
+ Coverage 80.06% 82.30% +2.24%
==========================================
Files 190 238 +48
Lines 37181 43790 +6609
Branches 9450 10995 +1545
==========================================
+ Hits 29770 36043 +6273
- Misses 2997 3407 +410
+ Partials 4414 4340 -74 ☔ View full report in Codecov by Sentry. |
A previous change (commit 8d29760) added a workaround for a PostgreSQL bug related to table access methods that was fixed in PG 15.4. The workaround does a build-time check for the PG version to apply the fix, but this won't work across PG server upgrades. To avoid raising an error when running an extension compiled on PG < 15.4 on PG 15.4+, add also a runtime check.
erimatnor
force-pushed
the
fix-abi-issue-for-pg15
branch
from
1c8797a to
0e2c16c
Compare
|
I triggered an ABI run for this PR here: https://github.com/timescale/timescaledb/actions/runs/12750725375 |
|
@gayyappan, @svenklemm: please review this pull request.
|
fabriziomello
approved these changes
Jan 13, 2025
mkindahl
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change (commit 8d29760) added a workaround for a PostgreSQL bug related to table access methods that was fixed in PG 15.4. The workaround does a build-time check for the PG version to apply the fix, but this won't work across PG server upgrades.
To avoid raising an error when running an extension compiled on PG < 15.4 on PG 15.4+, add also a runtime check.
Disable-check: force-changelog-file