Set assert variables with PG_USED_FOR_ASSERTS_ONLY #7556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabriziomello, @akuzm: please review this pull request.
|
mkindahl
approved these changes
Dec 20, 2024
Couple of instances where variables are used for assertion only, which can trigger unused variable error on certain builds. Adding the necessary PG_USED_FOR_ASSERTS_ONLY fixes the problem.
antekresic
force-pushed
the
add_assert_only
branch
from
541e1b3 to
7f92c3f
Compare
|
One drawback is that if a function is called and populates such a variable, it cannot be optimized away (usually) since the compiler cannot decide if the function has any side-effects. This effectively means that this attribute just hides the warning, but the problem (of computing unnecessary values, which the warning is really about) is still there. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7556 +/- ##
==========================================
+ Coverage 80.06% 82.16% +2.09%
==========================================
Files 190 231 +41
Lines 37181 43373 +6192
Branches 9450 10909 +1459
==========================================
+ Hits 29770 35637 +5867
- Misses 2997 3402 +405
+ Partials 4414 4334 -80 ☔ View full report in Codecov by Sentry. |
fabriziomello
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of instances where variables are used for assertion only, which can trigger unused variable error on certain builds. Adding the necessary PG_USED_FOR_ASSERTS_ONLY fixes the problem.
Disable-check: force-changelog-file