Fix ABI build failure in recompress.c #7555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `attname` is only used in an assertion, causing warnings (or errors) when not built with assertions.
mkindahl
added
the
build
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7555 +/- ##
==========================================
+ Coverage 80.06% 82.24% +2.17%
==========================================
Files 190 230 +40
Lines 37181 43201 +6020
Branches 9450 10859 +1409
==========================================
+ Hits 29770 35529 +5759
- Misses 2997 3361 +364
+ Partials 4414 4311 -103 ☔ View full report in Codecov by Sentry. |
|
Closing in favor of #7556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
attnameis only used in an assertion, causing warnings (or errors) when not built with assertions.Disable-check: force-changelog-file