Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update setup and calibration #3

Merged
merged 7 commits into from
Dec 12, 2024
Merged

docs: update setup and calibration #3

merged 7 commits into from
Dec 12, 2024

Conversation

manato
Copy link
Collaborator

@manato manato commented Dec 11, 2024

Description

According to the update of DRS, I also updated the documents.
This PR includes the following modifications:

  • Add description for the dialogs regarding IDs shown by setup-drs.sh
  • Clarify the replace/copy/modify target files after the calibration processes

Related link

@manato manato mentioned this pull request Dec 11, 2024
Open
7 tasks
@manato manato requested review from 0x126, drwnz and miursh December 11, 2024 09:02
@manato
Copy link
Collaborator Author

manato commented Dec 11, 2024

@0x126 @miursh @drwnz
During the update of the documents, I added a description regarding base_link and drs_base_link in the final section of docs/calibration/index.md. I'd really appreciate it if you could check the description is correct/makes sense.

drwnz
drwnz requested changes Dec 11, 2024
View reviewed changes
docs/anvil_setup/index.md Outdated Show resolved Hide resolved
docs/anvil_setup/index.md Outdated Show resolved Hide resolved
docs/calibration/index.md Outdated Show resolved Hide resolved
docs/calibration/index.md Outdated Show resolved Hide resolved
docs/calibration/index.md Outdated Show resolved Hide resolved
docs/anvil_setup/index.md Outdated Show resolved Hide resolved
docs/anvil_setup/index.md Outdated Show resolved Hide resolved
docs/calibration/index.md Outdated Show resolved Hide resolved
docs/calibration/index.md Outdated Show resolved Hide resolved
docs/calibration/index.md Outdated Show resolved Hide resolved
manato and others added 3 commits December 11, 2024 18:33
drwnz
drwnz approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manato
fix: correct base_link description
46e245e 
Signed-off-by: Manato HIRABAYASHI <[email protected]>
@manato
docs: add overview of base_link
c806e0b 
Signed-off-by: Manato HIRABAYASHI <[email protected]>
@manato
Copy link
Collaborator Author

manato commented Dec 11, 2024

Sorry for my delayed update. I fixed the description of base_link and added a figure to show an overview of base_link, just in case.

@manato manato merged commit c696fc9 into main Dec 12, 2024
@manato manato deleted the docs/update_setup_and_calibration branch December 12, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwnz drwnz drwnz approved these changes

@0x126 0x126 Awaiting requested review from 0x126

@miursh miursh Awaiting requested review from miursh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manato @drwnz