Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add periodic tf publisher #15

Open
wants to merge 2 commits into
base: feat/L4T-R35.4.1
Choose a base branch
from

Conversation

manato
Copy link
Collaborator

@manato manato commented Dec 11, 2024

Description

  • This PR introduces periodic_tranfrom_publisher, which publishes TF data periodically for easy data handling in the later part.
  • This PR also replaces all static_transform_publisher in the drs_launch package with periodic_transform_publisher
  • Besides, TF publishing operations, which have been disabled till now, are revived by this PR

Related links

Tests performed

There is no change in DRS usage by this PR.

  • ros2 launch drs_launch drs_ecu(0|1).launch.xml should execute sensor drivers with TF broadcasting for the sensors that each ECU is in charge of.
  • ros2 launch drs_launch drs_offline.launch.xml also should work the same as before.
    • For convenience during the calibration processes, I added an option named publish_tf to drs_offline.launch.xml (default=True). If it is set to False, drs_offline.launch.xml will not broadcast TF.

Notes for reviewers

Interface changes

N/A

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@manato manato marked this pull request as ready for review December 11, 2024 09:01
@manato manato requested review from 0x126, drwnz and miursh December 11, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant