Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log_evaluator): style: Rename topic #8

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/use_case/annotationless_perception.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Launching the file executes the following steps:

1. Execute launch of evaluation node (`annotationless_perception_evaluator_node`), `logging_simulator.launch` file and `ros2 bag play` command
2. Autoware receives sensor data output from input rosbag and the perception module performs recognition.
3. The perception_online_evaluator publishes diagnostic topic to `/diagnostic/perception_online_evaluator/metrics`
3. The perception_online_evaluator publishes diagnostic topic to `/perception/perception_online_evaluator/metrics`
4. The evaluation node subscribes to the topic and evaluates data. The result is dumped into a file.
5. When the playback of the rosbag is finished, Autoware's launch is automatically terminated, and the evaluation is completed.

Expand All @@ -31,7 +31,7 @@ The following two values specified in the scenario or launch argument are used t
- Threshold
- PassRange(Coefficient to correct threshold)

Success or failure is determined for each status.name in `/diagnostic/perception_online_evaluator/metrics` according to the following rules.
Success or failure is determined for each status.name in `/perception/perception_online_evaluator/metrics` according to the following rules.
Items for which no threshold is set (min, max, mean) are always judged as normal. Only those items for which a threshold is specified are subject to evaluation.

#### min
Expand Down Expand Up @@ -67,7 +67,7 @@ Subscribed topics:

| Topic name | Data type |
| ----------------------------------------------- | ------------------------------------- |
| /diagnostic/perception_online_evaluator/metrics | diagnostic_msgs::msg::DiagnosticArray |
| /perception/perception_online_evaluator/metrics | diagnostic_msgs::msg::DiagnosticArray |

Published topics:

Expand Down
6 changes: 3 additions & 3 deletions docs/use_case/annotationless_perception.ja.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ launch を立ち上げると以下のことが実行され、評価される。

1. launch で評価ノード(`annotationless_perception_evaluator_node`)と `logging_simulator.launch`、`ros2 bag play`コマンドを立ち上げる
2. bag から出力されたセンサーデータを autoware が受け取って、perception モジュールが認識を行う
3. perception_online_evaluator が `/diagnostic/perception_online_evaluator/metrics`に診断結果を出力する
3. perception_online_evaluator が `/perception/perception_online_evaluator/metrics`に診断結果を出力する
4. 評価ノードが topic を subscribe して、各基準を満たしているかを判定して結果をファイルに記録する
5. bag の再生が終了すると自動で launch が終了して評価が終了する

Expand All @@ -31,7 +31,7 @@ topic の subscribe 1 回につき、認識クラス毎に以下に記述する
- 閾値
- 合格範囲(閾値を補正する係数)

`/diagnostic/perception_online_evaluator/metrics` のstatus.name毎に以下のルールに従い成否の判定が行われる。
`/perception/perception_online_evaluator/metrics` のstatus.name毎に以下のルールに従い成否の判定が行われる。
閾値が設定されてない項目(min, max, mean)に関しては常に正常と判定される。指定があるもののみが評価対象になる。

#### min
Expand Down Expand Up @@ -67,7 +67,7 @@ Subscribed topics:

| Topic name | Data type |
| ----------------------------------------------- | ------------------------------------- |
| /diagnostic/perception_online_evaluator/metrics | diagnostic_msgs::msg::DiagnosticArray |
| /perception/perception_online_evaluator/metrics | diagnostic_msgs::msg::DiagnosticArray |

Published topics:

Expand Down
2 changes: 1 addition & 1 deletion log_evaluator/log_evaluator/launch_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
|^/perception/object_recognition/objects$\
|^/perception/object_recognition/tracking/multi_object_tracker/debug/.*\
|^/perception/object_recognition/detection/.*/debug/pipeline_latency_ms$\
|^/diagnostic/perception_online_evaluator/.*\
|^/perception/perception_online_evaluator/.*\
"""

ANNOTATIONLESS_PERCEPTION_AUTOWARE_ARGS = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def __init__(self, name: str) -> None:

self.__sub_diagnostics = self.create_subscription(
DiagnosticArray,
"/diagnostic/perception_online_evaluator/metrics",
"/perception/perception_online_evaluator/metrics",
self.diagnostics_cb,
1,
)
Expand Down
Loading