Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log_evaluator): style: Rename topic #8

Closed
wants to merge 1 commit into from

Conversation

Kazunori-Nakajima
Copy link

Sorry for the very long delay, topic name change!
We have not been able to debug it, so please let us know if you think something is amiss. 🙇‍♂

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Description

How to review this PR

Others

Signed-off-by: Kazunori-Nakajima <[email protected]>
@Kazunori-Nakajima Kazunori-Nakajima changed the title style: Rename topic feat(log_evaluator): style: Rename topic Jul 29, 2024
@hayato-m126
Copy link
Collaborator

Thank you for the PR.
However, the same content is merged against driving_log_replayer.
https://github.com/tier4/driving_log_replayer/pull/529/files

The log_evaluator shares history with driving_log_replayer.
For bug fixes and fixes to existing features, it is possible to put a PR in driving_log_replayer and merge the main of driving_log_replayer into log_evaluator.
Therefore, there is no need to submit PRs to both driving_log_replayer and log_evaluator.

PR頂きありがとうございます。
しかし、同じ内容がdriving_log_replayerに対してマージされています。
https://github.com/tier4/driving_log_replayer/pull/529/files

log_evaluatorはdriving_log_replayerと履歴を共有しています。
bug fixや、既存機能の修正に関しては、driving_log_replayerにPRを入れ、driving_log_replayerのmainをlog_evalutorにマージすることが可能です。
なので、driving_log_replayerとlog_evaluatorの両方にPRを出す必要はありません。

@hayato-m126 hayato-m126 deleted the nakajima branch July 29, 2024 04:03
@hayato-m126
Copy link
Collaborator

I merged this PR change 886399e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants