Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

feat: add covariance information in jsonl #568

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Oct 1, 2024

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Description

Author wants to add covariance information into jsonl. This will help to evaluate centerpoint_sigma model. See https://tier4.atlassian.net/browse/RT1-8002 for TIER IV members.

This PR must merged after tier4/autoware_perception_evaluation#190.

How to review this PR

Run evaluator and see the result.

Others

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Oct 1, 2024

Signed-off-by: yoshiri <[email protected]>
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Oct 1, 2024

Copy link
Collaborator

@hayato-m126 hayato-m126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix unit test

AttributeError: 'ObjectState' object has no attribute 'has_pose_covariance'

@ktro2828
Copy link
Contributor

ktro2828 commented Oct 2, 2024

@YoshiRi @hayato-m126 After releasing perception eval, unit testing succeeded

@YoshiRi YoshiRi dismissed hayato-m126’s stale review October 2, 2024 10:51

already satisfied

@YoshiRi YoshiRi merged commit 5246956 into develop Oct 2, 2024
4 checks passed
@YoshiRi YoshiRi deleted the feat/add_covariance_to_jsonl branch October 2, 2024 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants