-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prediction): add support of prediction evaluation #11
Open
ktro2828
wants to merge
17
commits into
develop
Choose a base branch
from
feat/prediction-evaluation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktro2828
force-pushed
the
feat/prediction-evaluation
branch
from
October 7, 2022 05:59
c085924
to
b7e6495
Compare
ktro2828
added
the
prediction
Updates related to motion prediction evaluation task
label
Oct 17, 2022
ktro2828
force-pushed
the
feat/prediction-evaluation
branch
2 times, most recently
from
October 20, 2022 00:58
ef90908
to
8f5009b
Compare
ktro2828
force-pushed
the
feat/prediction-evaluation
branch
4 times, most recently
from
November 15, 2022 04:35
17dd596
to
8de904a
Compare
ktro2828
force-pushed
the
feat/prediction-evaluation
branch
from
January 27, 2023 01:39
59633ed
to
cfd51cb
Compare
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
…ings Signed-off-by: ktro2828 <[email protected]>
ktro2828
force-pushed
the
feat/prediction-evaluation
branch
from
January 30, 2023 03:25
cfd51cb
to
0b167ae
Compare
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
This was referenced Oct 24, 2024
hayato-m126
reviewed
Oct 25, 2024
Signed-off-by: ktro2828 <[email protected]>
I performed a coupled test with the following PR, but got the following error tier4/driving_log_replayer_v2#40 [perception_evaluator_node.py-91] [2024-11-13 14:07:46,718] [INFO] [dataset.py:346 get_interpolated_now_frame] Only before frame is available for interpolation
[perception_evaluator_node.py-91] Traceback (most recent call last):
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/driving_log_replayer_v2/lib/driving_log_replayer_v2/perception_evaluator_node.py", line 372, in <module>
[perception_evaluator_node.py-91] main()
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/driving_log_replayer_v2/local/lib/python3.10/dist-packages/driving_log_replayer_v2/evaluator.py", line 203, in wrapper
[perception_evaluator_node.py-91] executor.spin()
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 294, in spin
[perception_evaluator_node.py-91] self.spin_once()
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 794, in spin_once
[perception_evaluator_node.py-91] self._spin_once_impl(timeout_sec)
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 791, in _spin_once_impl
[perception_evaluator_node.py-91] future.result()
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/task.py", line 94, in result
[perception_evaluator_node.py-91] raise self.exception()
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/task.py", line 239, in __call__
[perception_evaluator_node.py-91] self._handler.send(None)
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 437, in handler
[perception_evaluator_node.py-91] await call_coroutine(entity, arg)
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 362, in _execute_subscription
[perception_evaluator_node.py-91] await await_or_execute(sub.callback, msg)
[perception_evaluator_node.py-91] File "/opt/ros/humble/local/lib/python3.10/dist-packages/rclpy/executors.py", line 107, in await_or_execute
[perception_evaluator_node.py-91] return callback(*args)
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/driving_log_replayer_v2/lib/driving_log_replayer_v2/perception_evaluator_node.py", line 280, in perception_cb
[perception_evaluator_node.py-91] frame_result: PerceptionFrameResult = self.__evaluator.add_frame_result(
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/perception_eval/local/lib/python3.10/dist-packages/perception_eval/manager/perception_evaluation_manager.py", line 122, in add_frame_result
[perception_evaluator_node.py-91] result.evaluate_frame(previous_result=self.frame_results[-1])
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/perception_eval/local/lib/python3.10/dist-packages/perception_eval/evaluation/result/perception_frame_result.py", line 142, in evaluate_frame
[perception_evaluator_node.py-91] self.metrics_score.evaluate_prediction(object_results_dict, num_ground_truth_dict)
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/perception_eval/local/lib/python3.10/dist-packages/perception_eval/evaluation/metrics/metrics.py", line 250, in evaluate_prediction
[perception_evaluator_node.py-91] prediction_score_ = PredictionMetricsScore(
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/perception_eval/local/lib/python3.10/dist-packages/perception_eval/evaluation/metrics/prediction/prediction_metrics_score.py", line 54, in __init__
[perception_evaluator_node.py-91] displacement_err = PathDisplacementError(
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/perception_eval/local/lib/python3.10/dist-packages/perception_eval/evaluation/metrics/prediction/path_displacement_error.py", line 73, in __init__
[perception_evaluator_node.py-91] self.ade, self.fde, self.miss_rate = self._calculate_displacement_error(
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/perception_eval/local/lib/python3.10/dist-packages/perception_eval/evaluation/metrics/prediction/path_displacement_error.py", line 103, in _calculate_displacement_error
[perception_evaluator_node.py-91] estimation, ground_truth = prepare_path(result, self.top_k)
[perception_evaluator_node.py-91] File "/home/hyt/ros_ws/unlabeled/install/perception_eval/local/lib/python3.10/dist-packages/perception_eval/evaluation/metrics/prediction/utils.py", line 41, in prepare_path
[perception_evaluator_node.py-91] estimated_object_.predicted_paths.sort(key=lambda x: x.confidence, reverse=True)
[perception_evaluator_node.py-91] AttributeError: 'NoneType' object has no attribute 'sort' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ktro2828 [email protected]
Category
What
Add support of prediction evaluation.
Related to #6
Type of change
Test performed
Reference
Notes for reviewer