-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interactive calibrator - new api #179
base: tier4/universe
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Test that the sensor_calibration_manager is able to launch the calibrator in the default project.
*Tested |
@knzo25 got it! |
@vividf ? |
…d fixed some bugs Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
1cf3e2b
to
357dced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run the interactive calibrator in the default project with the camera_lidar.db3 rosbag provided in the pnp tutorial.
However, camera image didn't show up in the UI and the pointcloud didn't show up in the rviz2.
Could you provide more detail information how you test this PR?
Filter size: 10 | ||
History Policy: Keep Last | ||
Reliability Policy: Best Effort | ||
Value: /sensing/lidar/concatenated/pointcloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the default value to the input pointcloud instead of the concatenated pointcloud
Description
This should be reviewed after the documentation gets merged (and rebased before merged)
It is has little to no priority compared with other calibration tools tasks
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.