-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37453 - Support Zeitwerk loader #895
Fixes #37453 - Support Zeitwerk loader #895
Conversation
We support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is unhappy:
NoMethodError: undefined method `config' for nil:NilClass
test/test_helper.rb:181:in `setup_set_script_name'
test/test_helper.rb:84:in `before_setup'
Looks like some test doesn't set @controller
, which is weird because this isn't changing any of that and we haven't changed it in Foreman itself either.
ec867e5
to
049e637
Compare
It was a silly mistake in test/functional/ui_job_wizard_controller_test.rb. The test case's class name should comply with the actual controller (Ui -> UI). |
@evgeni this failed to build and has already been rotated, but I'm assumed it failed to build because it needs a patched Foreman and/or foreman-tasks. I recall you did something similar with a lookaside repo. Do you recall how? |
If the only thing you need is a build against a Zeitwerk-enabled Foreman: Add the packit for theforeman/foreman#10131 to |
Ah yes. Looks like I'll manually compose a repository with all packages. Then it's also an easy place to test everything. |
That's what I did for webpack5, and it was quite fine to test with |
049e637
to
295772a
Compare
295772a
to
a08d7ea
Compare
a08d7ea
to
5276f11
Compare
e43abca
to
cc3997c
Compare
Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: |
cc3997c
to
5fa9939
Compare
5fa9939
to
e75d04a
Compare
Thank you @ofedoren ! |
WIPrequires theforeman/foreman-tasks#752