Fixes #37471 - Support Zeitwerk loader #10997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to check out:
I tested
Seems all good so far! I grepped development.log for |
|
also notable: With the foreman-tasks PR checked out, I did not see this error which is currently failing in CI. |
ofedoren
force-pushed
the
feat-37471-support-zeitwerk
branch
from
8859c89 to
0c72da8
Compare
ofedoren
force-pushed
the
feat-37471-support-zeitwerk
branch
2 times, most recently
from
2b22e7c to
711dc2b
Compare
ofedoren
force-pushed
the
feat-37471-support-zeitwerk
branch
4 times, most recently
from
66d1f0d to
c3daa15
Compare
ofedoren
force-pushed
the
feat-37471-support-zeitwerk
branch
2 times, most recently
from
0f4329a to
f30c895
Compare
ofedoren
force-pushed
the
feat-37471-support-zeitwerk
branch
5 times, most recently
from
48f3162 to
cb2a1ae
Compare
|
Ready to merge after theforeman/foreman#10131 is merged, dropped the commit for testing with Foreman PR, the latest run was green: |
ofedoren
force-pushed
the
feat-37471-support-zeitwerk
branch
from
cb2a1ae to
a7bc48d
Compare
|
@ofedoren any idea why the tests are failing? |
|
The failures in |
|
@jeremylenz can you merge it then? :) |
jeremylenz
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIPWhat are the changes introduced in this pull request?
This PR should make Katello plugin compatible with Zeitwerk autoloader, which will be enabled in Foreman instead of classic Rails' loader.
Considerations taken when implementing this change?
I was trying to change rather less than more. Although, some stuff (like CV acronym) can be introduced, but will require more changes and I'm not sure it'll be quite safe. It's up to maintainers.
What are the testing steps for this pull request?
Test with Foreman main PR (included in CI workflow) and hope for the best. Note: at first it'll be red, since some plugins, which are dependencies, should be updated as well. Additionally, after the tests are green I strongly recommend to test out basic/advanced content related workflows live.