Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36837 - Template for convert2rhel analyze #840

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

stejskalleos
Copy link
Contributor

No description provided.

@stejskalleos
Copy link
Contributor Author

@adamruzicka review please

@stejskalleos
Copy link
Contributor Author

Updated

  • Check for RH OS family
  • root check
  • installing tool if not present
  • if any errors or warnings are present, exit 1

How to install the tool: https://developers.redhat.com/articles/2023/04/11/how-use-convert2rhel-migrate-centos-rhel?source=sso

Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion to make things a bit simpler if we can't get the counts anyway

app/views/templates/script/convert2rhel_analyze.erb Outdated Show resolved Hide resolved
app/views/templates/script/convert2rhel_analyze.erb Outdated Show resolved Hide resolved
@adamruzicka adamruzicka merged commit eb872a5 into theforeman:master Oct 23, 2023
3 of 4 checks passed
adamruzicka pushed a commit that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants