Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-conversion check in Convert2RHEL #2605

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add pre-conversion check in Convert2RHEL #2605

merged 1 commit into from
Nov 28, 2023

Conversation

Lennonka
Copy link
Contributor

@Lennonka Lennonka commented Nov 24, 2023 •
edited
Loading

Documents theforeman/foreman_remote_execution#840, i.e. Convert2RHEL analyze template

Please cherry-pick my commits into:

  • Foreman 3.9 if available

@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Nov 24, 2023
@Lennonka
Copy link
Contributor Author

Lennonka commented Nov 24, 2023 •
edited
Loading

@stejskalleos Questions:

  1. In which Foreman can this be expected? 3.9+?
  2. Is this step optional?
  3. Should this step replace any prerequisites?

@Lennonka
Copy link
Contributor Author

This should be merged after #2604

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2023 •
edited
Loading

The PR preview for 7bc59f3 is available at theforeman-foreman-documentation-preview-pr-2605.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@stejskalleos
Copy link
Contributor

stejskalleos commented Nov 28, 2023 •
edited
Loading

In which Foreman can this be expected? 3.9+? Yes
Is this step optional? Well, yes and no. Yes if you are an adventurous person, otherwise no. You can start the conversion process without it, but that doesn't sound to me like a good idea.
Should this step replace any prerequisites? I don't think so.

@Lennonka Lennonka force-pushed the SAT-20928-preconversion-checks-c2r branch from d867546 to 7bc59f3 Compare November 28, 2023 10:57
@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective labels Nov 28, 2023
adamlazik1
adamlazik1 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good stylewise.

@Lennonka Lennonka merged commit 3bea70a into theforeman:master Nov 28, 2023
7 checks passed
@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Nov 28, 2023
@Lennonka Lennonka deleted the SAT-20928-preconversion-checks-c2r branch November 28, 2023 18:34
@Lennonka
Copy link
Contributor Author

I've verified that this has to be cherry-picked:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stejskalleos stejskalleos stejskalleos left review comments

@adamlazik1 adamlazik1 adamlazik1 approved these changes

Assignees
No one assigned
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lennonka @stejskalleos @adamlazik1