Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with NodeJS 18 #693

Closed
wants to merge 1 commit into from
Closed

Test with NodeJS 18 #693

wants to merge 1 commit into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 8, 2024

No description provided.

@ekohl
Copy link
Member Author

ekohl commented Feb 8, 2024

Could be related:

Error:
HostgroupJsTest#test_0001_hostgroup without roles should have disabled links:
ActionController::RoutingError: No route matches [GET] "/webpack/foreman-vendor.css"
    lib/foreman/middleware/logging_context_request.rb:11:in `call'

Error:
HostgroupJsTest#test_0002_hostgroup with roles should have clickable links:
ActionController::RoutingError: No route matches [GET] "/webpack/foreman-vendor.css"
    lib/foreman/middleware/logging_context_request.rb:11:in `call'

@ekohl
Copy link
Member Author

ekohl commented Feb 14, 2024

With theforeman/foreman#10045 merged I'd expect this to pass so I've pushed an update to restart the tests.

@ekohl
Copy link
Member Author

ekohl commented Feb 14, 2024

Oh, @MariaAga's branch doesn't contain the fix. @MariaAga can you rebase your NodeJS 18 commit on Foreman develop?

@MariaAga
Copy link
Member

rebase your NodeJS 18 commit on Foreman develop?

Done

@ekohl
Copy link
Member Author

ekohl commented Feb 15, 2024

This is green (except for the Redmine issues test), so that's great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants