Refs #37102 - Read real webpack manifest in test #10045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It makes theforeman/foreman_discovery#622 pass where it previously failed. @MariaAga could you have a look? Edit: I know this breaks the functional tests. But perhaps we should deal with that in a different way? Like mocking/stubbing. |
I couldnt get it to work with any mock/stub I tried |
|
I think I'll update the stubbed implementation to read if it exists and otherwise use the current implementation. Writing out a file to disk in tests is also ugly and likely to cause problems. |
In some test cases (like controller tests) the real manifest isn't needed, but in integration tests they are. Rails has deprecated controller tests in favor of integration tests, but Foreman still has them. This modifies the fake read_webpack_manifest to read the manifest if available, otherwise pretend it's there.
ekohl
force-pushed
the
remove-webpack-manifest-hack
branch
from
2ac9cbf to
d48eb54
Compare
ekohl
changed the title
|
Verified that theforeman/foreman_discovery#622 passes with this. |
MariaAga
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system tests rely on this actually working.
This is to investigate the failures seen in theforeman/foreman_ansible#693 and theforeman/foreman_ansible#693. They also happen with current Foreman develop.