Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37103 - Update kwargs usage to comply with Ruby 3 #739

Closed

Conversation

ofedoren
Copy link
Member

Needs original (Dynflow/dynflow#439) and follow up fix (adamruzicka/dynflow#2) for Dynflow.

@adamruzicka
Copy link
Contributor

Could you bump the ruby parser version to 2.7?

@ofedoren ofedoren force-pushed the feat-37103-kwargs-compat branch from bef7184 to fd71b0b Compare January 25, 2024 13:55
@ofedoren
Copy link
Member Author

Hmm.. That was unexpected 🍏. I run it locally and it failed without Dynflow changes. But I was running test on Ruby 3 though...

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also declare the Ruby versions in the gemspec?

@ofedoren
Copy link
Member Author

Closing in favor of #743.

@ofedoren ofedoren closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants