Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on ruby 3 #737

Closed
wants to merge 2 commits into from
Closed

Test on ruby 3 #737

wants to merge 2 commits into from

Conversation

adamruzicka
Copy link
Contributor

No description provided.

@ekohl
Copy link
Member

ekohl commented Feb 1, 2024

Why weren't #739 and #740 uncovered by this? Is that a lack of testing coverage?

@adamruzicka
Copy link
Contributor Author

My take is that dynflow and tasks didn't use keywords at all, so it was ruby 3 compatible and this passed. Once we started adding keywords, all the small differences between how 2.7 and 3.0 handle them started to pop up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants