Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new comment is added, it now displays in the UI. It uses optimistic UI to immediately render the new comment, then updates based on the GraphQL mutation response. This fulfills this exercise:
https://www.robinwieruch.de/react-graphql-apollo-tutorial#exercise-commenting-feature
Known issues
Missing author.login
The author's login isn't being fetched, so during the optimistic UI rendering and before the server responds to the
addComment
mutation, the author's login is displayed asme
.During optimistic UI:
After server response
Paginating after new comment insertion
Update 2020-01-18: this has been fixed. See comment below.
When paginating after a new comment is inserted, and when the newly inserted comment returns from the server through pagination, this results in an ID conflict:
This also results in a duplicate comment, even through they have the same ID.
To reproduce:
More Comments
until the newly inserted comment appears a second timeCan you please suggest how we can remedy this problem?